Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static analysis issues JSC 2.1 #127

Closed
2 tasks done
chillfig opened this issue Apr 24, 2024 · 0 comments · Fixed by #130
Closed
2 tasks done

Static analysis issues JSC 2.1 #127

chillfig opened this issue Apr 24, 2024 · 0 comments · Fixed by #130
Assignees
@chillfig
Labels
bug

Comments

@chillfig
Copy link
Contributor

chillfig commented Apr 24, 2024 •
edited
Loading

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Handful of static analysis issues. This report records the findings from the static analysis to facilitate their tracking.

Source Folder Source Filename Source Line Source Object Disposition
Integer Overflow        
\apps\ds\fsw\src ds_table.c 423 Result Will Fix. DS PR #130
\apps\ds\fsw\src ds_table.c 545 Result Will Fix. DS PR #130
Unsafe Functions        
\apps\ds\fsw\src ds_cmds.c 1099 strncpy Will Fix. DS PR #130
\apps\ds\fsw\src ds_file.c 886 strncpy Will Fix. DS PR #130
\apps\ds\fsw\src ds_file.c 1001 strncpy Will Fix. DS PR #130
Off by One        
\apps\ds\fsw\src ds_app.c 361 FilterTblFilename Will Fix. DS PR #130
\apps\ds\fsw\src ds_cmds.c 1099 sizeof Will Fix. DS PR #130
\apps\ds\fsw\src ds_file.c 886 sizeof Will Fix. DS PR #130
\apps\ds\fsw\src ds_file.c 1001 sizeof Will Fix. DS PR #130
Buffer Improper Access        
\apps\ds\fsw\src ds_app.c 361 FilterTblFilename Will Fix. DS PR #130

To Reproduce
N/A. These issues were communicated by JSC.

Expected behavior
Need to resolve these. Should resolve and/or disposition the higher ranked ones at minimum.

Code snips
N/A

System observed on:
N/A

Additional context
N/A

Reporter Info
Imported from JSC 2.1 static analysis
Source Folder Source Filename Source Line Source Object Disposition
Integer Overflow
\apps\ds\fsw\src ds_table.c 423 Result Will Fix. DS PR #130

\apps\ds\fsw\src ds_table.c 545 Result Will Fix. DS PR #130

Unsafe Functions
\apps\ds\fsw\src ds_cmds.c 1099 strncpy Will Fix. DS PR #130

\apps\ds\fsw\src ds_file.c 886 strncpy Will Fix. DS PR #130

\apps\ds\fsw\src ds_file.c 1001 strncpy Will Fix. DS PR #130

Off by One
\apps\ds\fsw\src ds_app.c 361 FilterTblFilename Will Fix. DS PR #130

\apps\ds\fsw\src ds_cmds.c 1099 sizeof Will Fix. DS PR #130

\apps\ds\fsw\src ds_file.c 886 sizeof Will Fix. DS PR #130

\apps\ds\fsw\src ds_file.c 1001 sizeof Will Fix. DS PR #130

Buffer Improper Access
\apps\ds\fsw\src ds_app.c 361 FilterTblFilename Will Fix. DS PR #130
@chillfig chillfig added the bug label Apr 24, 2024
@chillfig chillfig self-assigned this Apr 24, 2024
chillfig pushed a commit to chillfig/DS that referenced this issue Jun 10, 2024
Fix nasa#127, Adds JSC 2.1 Static Analysis comments
63ce57a
@chillfig chillfig mentioned this issue Jun 10, 2024
Merged
2 tasks
chillfig pushed a commit to chillfig/DS that referenced this issue Jun 10, 2024
Fix nasa#127, Adds JSC 2.1 Static Analysis comments
f4a7227
chillfig pushed a commit to chillfig/DS that referenced this issue Jun 13, 2024
Fix nasa#127, Adds static analysis comments and replaces strncpy with…
06125af 
… snprintf

This commit addresses issues flagged during static analysis by:
- Adding JSC 2.1 disposition comments.
- Replacing strncpy with snprintf to enhance safety and compliance.
chillfig pushed a commit to chillfig/DS that referenced this issue Jun 14, 2024
Fix nasa#127, Adds static analysis comments and replaces strncpy with…
97eb89b 
… snprintf

This commit addresses issues flagged during static analysis by:
- Adding JSC 2.1 disposition comments.
- Replacing strncpy with snprintf to enhance safety and compliance.
- Changes DS_TABLE_VERIFY_ERR from 0xFFFFFFFF to -1
chillfig pushed a commit to chillfig/DS that referenced this issue Jun 14, 2024
Fix nasa#127, Adds static analysis comments and replaces strncpy with…
74cb926 
… snprintf

This commit addresses issues flagged during static analysis by:
- Adding JSC 2.1 disposition comments.
- Replacing strncpy with snprintf to enhance safety and compliance.
- Changes DS_TABLE_VERIFY_ERR from 0xFFFFFFFF to -1
dzbaker added a commit that referenced this issue Jun 27, 2024
@dzbaker
Merge pull request #130 from chillfig/SA_jsc2_1
c83933f 
Fix #127, Adds static analysis comments and replace strncpy with snprintf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chillfig chillfig

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #127, Adds static analysis comments and replace strncpy with snprintf chillfig/DS
1 participant
@chillfig