Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #127, Adds static analysis comments and replace strncpy with snprintf #130

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fix #127, Adds static analysis comments and replace strncpy with snprintf #130

merged 1 commit into from
Jun 27, 2024

Conversation

chillfig
Copy link
Contributor

@chillfig chillfig commented Jun 10, 2024 •
edited
Loading

Checklist (Please check before submitting)

Describe the contribution

  • Fixes Static analysis issues JSC 2.1 #127, Adds dispositions to line of code in question from static analysis stating why it's safe to keep as-is. Replacing strncpy with snprintf to enhance safety and compliance. Changes DS_TABLE_VERIFY_ERR from 0xFFFFFFFF to -1.

Testing performed
Manual Inspection

Expected behavior changes
N/A

System(s) tested on
N/A

Additional context
N/A

Third party code
N/A

Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, Vantage Systems

@chillfig chillfig self-assigned this Jun 10, 2024
@chillfig chillfig force-pushed the SA_jsc2_1 branch 2 times, most recently from f4a7227 to 06125af Compare June 13, 2024 17:55
@chillfig chillfig changed the title Fix #127, Adds JSC 2.1 Static Analysis comments Fix #127, Adds static analysis comments and replace strncpy with snprintf Jun 13, 2024
chillfig
chillfig commented Jun 14, 2024
View reviewed changes
Copy link
Contributor Author

@chillfig chillfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DS_TABLE_VERIFY_ERR has been updated to -1

fsw/src/ds_table.c Outdated Show resolved Hide resolved
@chillfig
Fix nasa#127, Adds static analysis comments and replaces strncpy with…
a5f1a8e 
… snprintf

This commit addresses issues flagged during static analysis by:
- Adding JSC 2.1 disposition comments.
- Replacing strncpy with snprintf to enhance safety and compliance.
- Changes DS_TABLE_VERIFY_ERR from 0xFFFFFFFF to -1
@chillfig chillfig mentioned this pull request Jun 21, 2024
Closed
2 tasks
@dzbaker dzbaker merged commit c83933f into nasa:main Jun 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chillfig chillfig

Labels
bug CCB:Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Static analysis issues JSC 2.1
2 participants
@chillfig @dzbaker