Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change format string to avoid "‘%s’ directive argument is null error" #63

Closed
2 tasks done
thnkslprpt opened this issue Nov 2, 2022 · 0 comments · Fixed by #64
Closed
2 tasks done

Change format string to avoid "‘%s’ directive argument is null error" #63

thnkslprpt opened this issue Nov 2, 2022 · 0 comments · Fixed by #64
Milestone

Comments

@thnkslprpt
Copy link
Contributor

thnkslprpt commented Nov 2, 2022

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Build + Run workflow fails due to GCC warning (treated as error) of potential NULL argument being passed to format string.
This issue was noticed/raised here in PR #61 (comment)

To Reproduce
Run CI workflow (specifically [Build and run with startup msg verification) and observe error.

Expected behavior
CI workflow run without failure.

Code snips

/home/runner/work/DS/DS/apps/ds/fsw/src/ds_file.c:881:13: error: ‘%s’ directive argument is null [-Werror=format-overflow=]
  881 |             CFE_EVS_SendEvent(DS_MOVE_FILE_ERR_EID, CFE_EVS_EventType_ERROR,
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  882 |                               "FILE MOVE error: dir name = '%s', filename = '%s'", PathName, FileName);

Reporter Info
Avi @thnkslprpt

thnkslprpt added a commit to thnkslprpt/DS that referenced this issue Nov 2, 2022
dzbaker added a commit that referenced this issue Nov 2, 2022
…-avoid-workflow-failure

Fix #63, Change format string to avoid GCC workflow failure
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants