Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #60, Apply consistent Event ID names to common events #61

Merged

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Oct 21, 2022

Checklist

Describe the contribution

Testing performed
Only GitHub CI actions.

Expected behavior changes
No impact on code behavior (no logic changes).
Consistent Event ID names for the events which are common to all/most cFS components and apps will improve consistency and ease make code review/debugging easier.

Contributor Info
Avi Weiss @thnkslprpt

@dzbaker dzbaker self-assigned this Oct 27, 2022
@dzbaker
Copy link
Contributor

dzbaker commented Oct 31, 2022

@thnkslprpt Are you able to resolve the workflow failures?

@thnkslprpt
Copy link
Contributor Author

@thnkslprpt Are you able to resolve the workflow failures?

I'm not quite sure what to do there - it's similar to the MD failures. Same workflow faillures on any run of the workflow, no matter what is changed.
image
image

The CodeQL alert is in the base branch as well I think:
image

@dzbaker dzbaker added this to the Fornax milestone Nov 21, 2022
@dzbaker dzbaker modified the milestones: Fornax, Equuleus Dec 7, 2022
@thnkslprpt thnkslprpt force-pushed the fix-60-apply-consistent-event-id-names branch from 4abe6c6 to 0049a21 Compare March 12, 2023 05:07
@thnkslprpt thnkslprpt force-pushed the fix-60-apply-consistent-event-id-names branch from 0049a21 to 17f4a52 Compare April 1, 2023 23:43
@thnkslprpt thnkslprpt force-pushed the fix-60-apply-consistent-event-id-names branch 2 times, most recently from e70d884 to 1daf6f7 Compare November 1, 2023 17:57
@thnkslprpt thnkslprpt force-pushed the fix-60-apply-consistent-event-id-names branch from 1daf6f7 to 05697ba Compare April 20, 2024 04:57
@dzbaker dzbaker merged commit 83ee61a into nasa:main Jul 15, 2024
17 checks passed
@thnkslprpt thnkslprpt deleted the fix-60-apply-consistent-event-id-names branch July 16, 2024 09:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Event ID naming
3 participants