Updated EA Diagnostics #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ather than just booleans
… eas call update diagnostics properly
…tests to make sure it is called correctly
…ed working on implementing types in VarAnd
…pring_mutation_type to mutation_offspring_type
…super constructor to set types correctly
nightdr
commented
Nov 8, 2022
| @@ -315,6 +330,7 @@ def test_impossible_param_or_prune_mutation(mocker, algo_index, | |||
| c_stack = child.mutable_command_array | |||
|
|
|||
| np.testing.assert_array_equal(c_stack, p_stack) | |||
| assert mutation.last_mutation_type == mutation.types[algo_index] # TODO should be None? | |||
There was a problem hiding this comment.
These test cases test when no mutation happens. Before the EA changes, we would set the last_mutation_type even if no mutation occurred (e.g., prune mutation got called but couldn't find a suitable subtree to prune), is this still the expected behavior?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging efforts to make EA diagnostics detailed on the level of mutation and crossover types.