Merge pull request #2303 from havencarlson/issue-1901

Fix #1901, remove else statement that was unreachable by unit tests
nasa · Apr 28, 2023 · 8721d21 · 8721d21
2 parents bf3dc55 + 972f76a
commit 8721d21
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 18 deletions.
diff --git a/modules/tbl/fsw/inc/cfe_tbl_events.h b/modules/tbl/fsw/inc/cfe_tbl_events.h
@@ -345,18 +345,6 @@
  */
 #define CFE_TBL_NO_WORK_BUFFERS_ERR_EID 60
 
-/**
- * \brief TBL Load Table Command Get Working Buffer Internal Failure Event ID
- *
- *  \par Type: ERROR
- *
- *  \par Cause:
- *
- *  \link #CFE_TBL_LOAD_CC TBL Load Table Command \endlink failure due to
- *  internal get working buffer error.
- */
-#define CFE_TBL_INTERNAL_ERROR_ERR_EID 61
-
 /**
  * \brief TBL Write File Creation Failure Event ID
  *

diff --git a/modules/tbl/fsw/src/cfe_tbl_task_cmds.c b/modules/tbl/fsw/src/cfe_tbl_task_cmds.c
@@ -475,16 +475,11 @@ int32 CFE_TBL_LoadCmd(const CFE_TBL_LoadCmd_t *data)
                                                   TblFileHeader.TableName);
                             }
                         }
-                        else if (Status == CFE_TBL_ERR_NO_BUFFER_AVAIL)
+                        else
                         {
                             CFE_EVS_SendEvent(CFE_TBL_NO_WORK_BUFFERS_ERR_EID, CFE_EVS_EventType_ERROR,
                                               "No working buffers available for table '%s'", TblFileHeader.TableName);
                         }
-                        else
-                        {
-                            CFE_EVS_SendEvent(CFE_TBL_INTERNAL_ERROR_ERR_EID, CFE_EVS_EventType_ERROR,
-                                              "Internal Error (Status=0x%08X)", (unsigned int)Status);
-                        }
                     }
                     else
                     {