Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused function CFE_ES_SysLog_snprintf in cfe_es_syslog.c #1636

Closed
pepepr08 opened this issue Jun 23, 2021 · 0 comments · Fixed by #1637
Closed

Remove unused function CFE_ES_SysLog_snprintf in cfe_es_syslog.c #1636

pepepr08 opened this issue Jun 23, 2021 · 0 comments · Fixed by #1637
Assignees
@pepepr08
Labels
enhancement
Milestone
Caelum

Comments

@pepepr08
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This function is not used. We also don't have UT for this function.

Describe the solution you'd like
Simply remove the code.

Describe alternatives you've considered
Keep it and add the unit tests.

Requester Info
Jose F Martinez Pedraza/NASA GSFC
pepepr08 added a commit to pepepr08/cFE that referenced this issue Jun 23, 2021
@pepepr08
Fix nasa#1636 Removed unused function CFE_ES_SysLog_snprintf
2d73c9b
@pepepr08 pepepr08 self-assigned this Jun 23, 2021
@pepepr08 pepepr08 mentioned this issue Jun 23, 2021
Merged
pepepr08 added a commit to pepepr08/cFE that referenced this issue Jun 23, 2021
@pepepr08
Fix nasa#1636 Removed unused function CFE_ES_SysLog_snprintf
f96f9db
@skliper skliper added this to the 7.0.0 milestone Jun 29, 2021
astrogeco added a commit that referenced this issue Jul 1, 2021
@astrogeco
Merge pull request #1637 from pepepr08/fix467-es-start-syslog
176e1ab 
Fix #467, #1636 Complete coverage for cfe_es_start.c and cfe_es_syslog.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pepepr08 pepepr08

Labels
enhancement
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Fix #467, #1636 Complete coverage for cfe_es_start.c and cfe_es_syslog.c pepepr08/cFE
2 participants
@pepepr08 @skliper