New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1472, Replace while loop with single memset #2182

Open

thnkslprpt wants to merge 1 commit into nasa:main from thnkslprpt:fix-1472-replace-while-with-single-memset

Contributor

thnkslprpt commented Oct 25, 2022 •

edited

Loading

Checklist

I reviewed the Contributing Guide.
I signed and emailed the appropriate Contributor License Agreement to GSFC-SoftwareRelease@mail.nasa.gov and copied cfs-program@lists.nasa.gov.

Describe the contribution

Fixes Replace loop with single memset in CFE_SB_SendStatsCmd #1472
- Removes unnecessary while loop in CFE_SB_SendStatsCmd() and sets entire block of memory pointed to by PipeStatPtr to 0 in a single memset (sized by remaining value of PipeStatCount).

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes
Achieves same result without going through the loop.

Contributor Info
Avi Weiss @thnkslprpt


          Fix nasa#1472, Replace while loop with single memset

c4ce598

thnkslprpt force-pushed the fix-1472-replace-while-with-single-memset branch from 64db8ec to c4ce598 Compare

March 14, 2023 11:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet