Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE testcase code should define its messages in proper header file #2484

Closed
jphickey opened this issue Dec 19, 2023 · 0 comments · Fixed by #2485
Closed

CFE testcase code should define its messages in proper header file #2484

jphickey opened this issue Dec 19, 2023 · 0 comments · Fixed by #2485
Assignees

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The "cfe_testcase" module has its own messages and msgids that it uses to test SB. However these are mostly just defined within the C file that has the test source code.

Describe the solution you'd like
This should follow the proper methods established elsewhere and define these messages and msg IDs in a separate header, using the current design and naming patterns.

Additional context
It may be just test code but there is no good reason to ignore the proper methods for doing this type of thing.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Dec 19, 2023
jphickey added a commit to jphickey/cFE that referenced this issue Dec 19, 2023
Move the message and table definitions into separate header files,
that follow the established naming patterns.
dzbaker added a commit that referenced this issue Jan 17, 2024
Fix #2484, implement header files for testcase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant