Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perfids default file missing #2487

Open
skliper opened this issue Dec 19, 2023 · 0 comments
Open

Perfids default file missing #2487

skliper opened this issue Dec 19, 2023 · 0 comments

Comments

@skliper
Copy link
Contributor

skliper commented Dec 19, 2023

Describe the bug
modules/core_api/config/default_cfe_perfids.h doesn't exist which is the fallback file used here if a custom override isn't added:

set(DEFAULT_SOURCE FALLBACK_FILE "${CMAKE_CURRENT_LIST_DIR}/config/default_${CORE_API_CFGFILE}")

if (NOT SELECTED_FILE AND LOCATEIMPL_ARG_FALLBACK_FILE)
if (IS_ABSOLUTE "${LOCATEIMPL_ARG_FALLBACK_FILE}")
set(SELECTED_FILE "${LOCATEIMPL_ARG_FALLBACK_FILE}")
else()
set(SELECTED_FILE "${CMAKE_CURRENT_LIST_DIR}/${LOCATEIMPL_ARG_FALLBACK_FILE}")
endif()
if (NOT EXISTS "${SELECTED_FILE}" AND NOT LOCATEIMPL_ARG_OPTIONAL)
message(FATAL_ERROR "No implementation for ${FILE_NAME} found")
endif()
endif()

To Reproduce
remove sample_defs/sample_perfids.h which per established patterns should use the default from cfe:

CMake Error at cmake/global_functions.cmake:84 (message):
  No implementation for perfids.h found,
  /home/jhageman/cFS/ds_cfs/cfe/modules/core_api/config/default_cfe_perfids.h
  doesn't exist
Call Stack (most recent call first):
  cmake/global_functions.cmake:187 (cfe_locate_implementation_file)
  modules/core_api/mission_build.cmake:43 (generate_config_includefile)
  cmake/mission_build.cmake:431 (include)
  CMakeLists.txt:120 (prepare)

Expected behavior
Really perfids is of the same nature as msgids since they need to be at minimum target unique. System should support overrides from a single file (like msgids). Consider either generalizing setup_platform_msgids to cover both msgids and perfids or add a function for perfids.

System observed on:

  • OS: Ubuntu 22.04
  • Versions: main-ish (close to main w/ project customizations)

Additional context
None

Reporter Info
Jacob Hageman - NASA/GSFC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant