Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests no longer installing correctly #881

Closed
skliper opened this issue Sep 10, 2020 · 4 comments · Fixed by #884 or #891
Closed

Unit tests no longer installing correctly #881

skliper opened this issue Sep 10, 2020 · 4 comments · Fixed by #884 or #891
Labels
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Sep 10, 2020

Describe the bug
Some unit tests show up in build directory after install

.../build$ ls -1
cfecfs_build_info.h.in
cfecfs_version_info.h.in
CMakeCache.txt
CMakeFiles
cmake_install.cmake
coverage-ut-mcp750-vxworks-testrunner
CTestTestfile.cmake
doc
exe
inc
install_manifest.txt
Makefile
mission_vars.cache
msg_UT
native
sample_app-sample_app-testrunner
sample_lib-sample_lib-testrunner
tools

To Reproduce
make SIMULATION=native ENABLE_UNIT_TESTS=true prep
make
make install

Expected behavior
They should all show up in build/exe/cpu1 (for default config)

Code snips
No idea

System observed on:

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: bundle main

Additional context
None

Reporter Info
Jacob Hageman - NASA/GSFC

@skliper skliper added the bug label Sep 10, 2020
@skliper
Copy link
Contributor Author

skliper commented Sep 10, 2020

@jphickey ideas? This from the cpu naming change?

@skliper
Copy link
Contributor Author

skliper commented Sep 11, 2020

-- Installing: .../build//sample_app-sample_app-testrunner (removed full path)... exe/cpu1 missing.

@skliper
Copy link
Contributor Author

skliper commented Sep 11, 2020

Survey:

add_test(${UT_TARGET_NAME}_UT ${UT_TARGET_NAME}_UT)
foreach(TGTNAME ${TGTSYS_${SYSVAR}})
install(TARGETS ${UT_TARGET_NAME}_UT DESTINATION ${TGTNAME}/${UT_INSTALL_SUBDIR})
endforeach(TGTNAME ${TGTSYS_${SYSVAR}})

https://github.com/nasa/osal/blob/c3b139863d7edfc904983bea050b2147c8b784ab/src/unit-test-coverage/CMakeLists.txt#L86-L88
https://github.com/nasa/osal/blob/c3b139863d7edfc904983bea050b2147c8b784ab/CMakeLists.txt#L319-L321
install(TARGETS ${DEP}_UT DESTINATION ${TGTNAME}/${UT_INSTALL_SUBDIR})

https://github.com/nasa/sample_app/blob/9ff605ed1b738c6a2eabd75cf05aeed163cc5940/unit-test/CMakeLists.txt#L70

@skliper
Copy link
Contributor Author

skliper commented Sep 11, 2020

Looks like a loop on INSTALL_TARGET_LIST should work since it's set at the arch level:

set(INSTALL_TARGET_LIST ${TGTSYS_${SYSVAR}})

I'll try making these all consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants