Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cFE Integration Candidate: 2021-01-05 #1066

Merged
merged 7 commits into from Jan 7, 2021
Merged

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Jan 6, 2021

Describe the contribution

Fix #1054, Resolve osal guide generation warnings
Fix #1059, Corrects documentation for CFE_SB_GetPipeName() stub
Fix #1064, Add cppcheck GitHub Actions workflow

Testing performed
Github Actions Run https://github.com/nasa/cFS/pull/172/checks

Expected behavior changes
PR #1056 - Resolved doxygen warnings osalguide and updated header file references

PR #1060 - Corrects the documentation for the CFE_SB_GetPipeName() unit test stub function.

PR #1065 - Adds a new github actions workflow file to run cppcheck

System(s) tested on
Ubuntu 18.04

Additional context
Part of nasa/cFS#172

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
@astrogeco
@CDKnightNASA
@skliper

@astrogeco
Copy link
Contributor Author

@skliper Th following unit test seems to be hanging with OMIT_DEPRECATED = true

Start 57: select-test

See https://github.com/nasa/cFS/runs/1653771649?check_suite_focus=true

@skliper
Copy link
Contributor

skliper commented Jan 6, 2021

@astrogeco There is a race in main right now, any test run might hang. See nasa/osal#721. Just requested that one get fast-tracked...

@jphickey
Copy link
Contributor

jphickey commented Jan 6, 2021

Yes- I can confirm this is the exact symptom of the race condition that is fixed by nasa/osal#721. It was in the previous build too (main branch) it is just that it doesn't get triggered with every run, so it wasn't noticed.

Fix #1064, Add cppcheck GitHub Actions workflow
Also update Readme.md
@astrogeco astrogeco marked this pull request as ready for review January 7, 2021 19:02
@astrogeco astrogeco merged commit 1ede295 into main Jan 7, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 7, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 7, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 7, 2021
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants