cFE Integration candidate: 2021-03-02 #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implmements a new function in FS to parse an input file name from a user. Initially applied to startup script processing. The new function produces fully-qualified output where the input may omit either a pathname or an extension. These items will be added from the specified defaults, if missing, and a complete fully-qualified filename will be output. If the input is already a fully qualified filename, then the output is the same as the input (basically a copy). This initially is used to provide better cross-platform startup script processing, where module suffix may differ across platforms. Only the "basename" of the filename needs to be specified in the startup script - everything else can come from defaults.
Combine the "zero copy" and the normal CFE buffer descriptor into a single unified CFE_SB_BufferD_t object. This cleans up a bunch of extra logic related to zero-copy buffers, including the extra descriptor object. The result is a simpler zero-copy design that is much less different from the standard (non-zero-copy) message path. All message descriptor objects are now tracked in a list by SB, not just the zero-copy descriptors (for consistency - if any buffers need to be tracked, they should all be tracked).
Fix #1020, refactor SB buffer descriptor object
Fix #922, Update cfe_error.h to use the CFE_Status_t type
Corrects two false alarms about uninitialized vars and another cast-align warning on the raspbian toolchain (gcc 4.9.3) or other older versions of gcc (e.g. RHEL/CentOS 7). - Promotes the CFE_SBR_INVALID_ROUTE_ID constant from the private cfe_sbr_priv.h header to the public cfe_sbr.h header (where the type itself is defined). - Pre-Initialize local stack variables that store outputs from other functions (avoids false warning about use-before-init). - Corrects an alignment warning on ARM.
…_guide Fix #1149, remove cfeesugshellsrv from user guide
Fix #981, implement better filename parser
Fix #1153, Remove logic based on LogEnabled status
Fix #1189, correct compiler warnings
Add 'v' prefix to version numbers in ReadMe
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Mar 4, 2021
Combines: - nasa/cFE#1196 - nasa/osal#835 - nasa/elf2cfetbl#72 Includes: - nasa/cFE#1154 - nasa/cFE#935 - nasa/cFE#1179 - nasa/cFE#1140 - nasa/cFE#1178 - nasa/cFE#1197 - nasa/osal#834 - nasa/osal#826 - nasa/osal#827 - nasa/osal#829 - nasa/osal#824 - nasa/elf2cfetbl#71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #1020, refactor SB buffer descriptor object
Fix #922, Update
cfe_error.hto use theCFE_Status_ttypeFix #1149, remove cfeesugshellsrv from user guide
Fix #546 , APIs missing argument validation
Fix #547 , APIs missing check for NULL pointer(s)
Fix #1119 , Calculate crc can't return error code
Fix #1153, Remove logic based on LogEnabled status
Fix #1189, correct compiler warnings
Testing performed
See https://github.com/nasa/cFS/pull/204/checks
Expected behavior changes
PR #1154 - Refactors the SB buffer descriptor object
CFE_SB_BufferD_tand simplify the zero-copy buffer paradigm. Combines the zero-copy and the normal CFE buffer descriptor into a single unifiedCFE_SB_BufferD_tobject. Results in a simpler zero-copy design that is similarto the the standard, non-zero-copy message path. All message descriptor objects are now tracked in a list by SB. All changes are internal to SB. This does not affect API or behavior of any existing APIs (but see note). Corrects a minor issue where theMsgSendErrorCounterwould get incremented if there were no subscribers, but only in the zero copy API.PR #935 - Replaces
int_32withCFE_Status_tfor all error message codesPR #1179 - Removes references to
cfeesugshellsrvfrom user guidePR #1140 - Adds null pointer checks and size checks to validate method parameters. Returning the input instead of an error code
PR #1178 - Removes use of
LogEnabledelement in HK telemetry for EVS logic since log is always enabled now. On failures, reset area or semaphore will panic.PR #1197 - Fixes various build warnings when
BUILDTYPE=release.System(s) tested on
Ubuntu 18.04
Additional context
Part of nasa/cFS#204
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey
@pducolin
@zanzaben
@skliper