Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1266, use events for CFE test asserts #1276

Merged

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Apr 1, 2021

Describe the contribution
Reports test failures as CFE events, which allows for more processing capability, and allows failures to be recieved externally (e.g. ground system).

Fixes #1266

Testing performed
Update startup script to load the CFE functional test libs + apps and execute CFE to run the tests.

Expected behavior changes
Test status messages sent as Events rather than Syslog.

System(s) tested on
Ubuntu 20.04

Additional context
Also tested in conjunction with #1251.

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Reports test failures as CFE events, which allows for more processing
capability, and allows failures to be recieved externally (e.g. ground system).
@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Apr 2, 2021
@astrogeco
Copy link
Contributor

astrogeco commented Apr 7, 2021

CCB:2021-04-07 APPROVED

  • gives more flexibility
  • enabling "debug events" still allows you to see everything
  • DOES NOT TOUCH fsw code
  • How much do we care about making the console output "pretty" for human eyes?
    • Don't add blank
  • There is another part to this fix, an old bug, to make events more configurable see EVS "output ports" should be a function of the PSP #94. This would enable using color coding and better parsing for people.
  • Other idea: change test cases from a library into an app so we can use the "start app" command to run tests.

@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Apr 9, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate April 12, 2021 02:41
@astrogeco astrogeco merged commit f8102e9 into nasa:integration-candidate Apr 12, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 12, 2021
Use events for CFE test asserts
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 12, 2021
Combines

nasa/osal#956
nasa/cFE#1295

Including:

nasa/osal#941 - Allow OSAL re-initialization
nasa/osal#941 - Combine initialized and shutdown flags into one
nasa/osal#948 - Add OS_API_Teardown
nasa/osal#948 - Black Box Unit Tests Do Not Ensure Resources Are Cleaned Up Between Tests
nasa/osal#940 - Rework shell test

nasa/cFE#1276 - Use events for CFE test asserts
@jphickey jphickey deleted the fix-1266-assert-events branch April 12, 2021 19:18
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFE_Assert should use SendEvent
3 participants