Fix #1515, Remove unnecessary memset from CFE_TBL_LoadFromFile #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have successfully added a new CodeQL configuration |
|
You have successfully added a new CodeQL configuration |
dzbaker
added
the
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jun 8, 2023
*Combines:* cFE v7.0.0-rc4+dev342 **Includes:** *cFE* - nasa/cFE#2369 - nasa/cFE#2272 - nasa/cFE#2276 Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com> Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jun 8, 2023
*Combines:* cFE v7.0.0-rc4+dev342 **Includes:** *cFE* - nasa/cFE#2369 - nasa/cFE#2272 - nasa/cFE#2276 Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com> Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
thnkslprpt
deleted the
fix-1515-remove-unnecessary-memset-from-tbl-loadfromfile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
memsetinCFE_TBL_LoadFromFile#1515memsetall to zero removed given that entire length is written to immediately after. Just set last character to null terminate.Testing performed
GitHub CI actions all passing successfully.
Expected behavior changes
No change.
Contributor Info
Avi Weiss @thnkslprpt