Fix #1930, add code coverage for null check #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avan989
force-pushed
the
1930-Null-Pointer-Coverage-Test
branch
2 times, most recently
from
ce626e1
to
33e92af
Compare
avan989
changed the title
avan989
force-pushed
the
1930-Null-Pointer-Coverage-Test
branch
from
33e92af
to
ed943d7
Compare
Fix nasa#1930, add code coverage for null check in es. Add CFE_ES_GenPoolCreatePoolBlock and CFE_ES_GenPoolRecyclePoolBlock to header file
avan989
force-pushed
the
1930-Null-Pointer-Coverage-Test
branch
from
ed943d7
to
9a16fd3
Compare
|
If this changes coverage, I recommend updating: cFE/.github/workflows/code-coverage.yml Lines 107 to 108 in 8852743 |
jphickey
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Looks good. The only note is that at some point we also need to update our workflow minimum enforcement. This has improved the line/branch coverage a bit so we should make sure we don't regress.
Those minimums are here:
cFE/.github/workflows/code-coverage.yml
Lines 107 to 108 in c1aa16a
My checks show that we are at 49 and 16 now, respectively.
dzbaker
added
the
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 23, 2023
*Combines:* cFE v7.0.0-rc4+dev405 **Includes:** *cFE* - nasa/cFE#2377 Co-authored by: Anh Van <avan989@users.noreply.github.com>
This was referenced Oct 23, 2023
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 23, 2023
*Combines:* cFE v7.0.0-rc4+dev405 **Includes:** *cFE* - nasa/cFE#2377 Co-authored by: Anh Van <avan989@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Fix #1930 update code coverage test for CFE_ES_GenPoolRecyclePoolBlock and CFE_ES_GenPoolCreatePoolBlock for null pointer check.
Testing performed
Steps taken to test the contribution:
Expected behavior changes
No impact on behavior
Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)
Anh Van, GSFC