Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #983 Updated the CFE_MISSION_TIME_DEF_LEAPS to 37 seconds #984

Conversation

zanzaben
Copy link
Contributor

@zanzaben zanzaben commented Oct 30, 2020

Describe the contribution
Fixes #983 by updating the sample config to 37

Testing performed
Built the sample config then with the ground tools sent CFE_TIME_SEND_DIAGNOSTIC_TLM_CC and verified AtToneLeapSeconds was 37

Expected behavior changes
The sample configs leap seconds will be up to date. (As of Oct 2020)

System(s) tested on
Ubuntu 18.04.5

Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell - NASA/GSFC

@skliper
Copy link
Contributor

skliper commented Nov 2, 2020

Nitpick - preferred commit comment: "Fix #983, Update CFE_MISSION_TIME_DEF_LEAPS to 37 seconds"

@astrogeco
Copy link
Contributor

Add, "Fix #983" or "Fixes #983" to make github link issue with pull request See https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue

@zanzaben zanzaben force-pushed the fix983-Sample-config-leap-seconds branch from bed5b80 to ef6bdf4 Compare November 2, 2020 16:33
@zanzaben zanzaben requested a review from skliper November 3, 2020 17:05
@zanzaben zanzaben added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Nov 3, 2020
@astrogeco astrogeco added CCB-20201104 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Nov 4, 2020
@astrogeco
Copy link
Contributor

CCB 2020-11-04 APPROVED

@astrogeco astrogeco changed the base branch from main to integration-candidate November 10, 2020 17:18
@astrogeco astrogeco merged commit a2879eb into nasa:integration-candidate Nov 10, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Nov 10, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Nov 16, 2020
* Add nasa/cFE#984

* Add nasa/cFE#980

* Add nasa/cFE#867

* Add nasa/osal#638 and update cfe due to rebase

* Add nasa/cFE#987

* Add nasa/to_lab#64 and nasa/sample_app#104

* Add nasa/osal#643

* Add nasa/cFE#1000

* Add nasa/ci_lab#58

* Add doxygen fixes for nasa/osal#643

* Add nasa/cFE#1013

* Add nasa/cFE#1011

* Add nasa/ci_lab#61

* Add nasa/sample_app#109

* Bump versions and point to submodules main

Co-authored-by: Joseph Hickey <joseph.p.hickey@nasa.gov>
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sample Config Leap Seconds needs update
3 participants