Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating install instructions for macOS #177

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

rokrsa
Copy link

@rokrsa rokrsa commented Apr 13, 2021

  • brew to install pyqt5
  • instead brew to install zeromq, install pyzmq via pip3

Describe the contribution
A clear and concise description of what the contribution is.

  • With make command, first it was not able to find the module PyQt5, then PyQt5.sip and later zmq. Hence i had to figure out the right way of installing these dependencies

Testing performed
Steps taken to test the contribution:

  1. Tested on Mac 10.15.7

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

  • python3 GroundSystem.py runs successfully.

System(s) tested on

  • Hardware:Macbook
  • OS: Mac OS X
  • Versions: 10.15.7

Contributor Info - All information REQUIRED for consideration of pull request
Personal

* brew to install pyqt5
* instead brew to install zeromq, install pyzmq via pip3
@skliper skliper requested a review from astrogeco April 14, 2021 13:35
Copy link
Contributor

@astrogeco astrogeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should instead use pip3 to install pyqt5.

See https://stackoverflow.com/questions/34583811/how-can-i-install-pyqt5-on-mac

Copy link
Author

@rokrsa rokrsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested pip3 based installation. It works as expected.

Using pip3 instead of brew
@rokrsa
Copy link
Author

rokrsa commented May 10, 2021

@astrogeco - i am not able to clearly understand the changes requested by you.

@astrogeco
Copy link
Contributor

My bad, I misread your changes. We're good to go!

@astrogeco
Copy link
Contributor

astrogeco commented May 11, 2021

Last step, if you haven't done so already, please download, sign, and email the appropriate Contributor License agreement below to GSFC-SoftwareRelease@mail.nasa.gov and cfs-program@lists.nasa.gov.

Corporate Contributor License agreement
Individual Contributor License agreement

Thank you so much or your contribution!

@astrogeco astrogeco added docs CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) pending CLA CCB:Approved Indicates approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels May 11, 2021
@astrogeco
Copy link
Contributor

@rokrsa can you submit the CLA?

@skliper skliper changed the title Updating commands for macOS Updating install instructions for macOS Jun 29, 2021
@astrogeco astrogeco removed the CCB:Approved Indicates approval by CCB label Jun 8, 2022
@dzbaker dzbaker self-assigned this Sep 8, 2022
@dzbaker
Copy link
Contributor

dzbaker commented Sep 8, 2022

CCB 8 September 2022: Need issue and need to test steps.

@dzbaker
Copy link
Contributor

dzbaker commented Oct 11, 2022

CCB 8 September 2022: Need issue and need to test steps.

@rokrsa Thank you for your contribution! I'm going through some of the older PRs to see if we can get them merged in. Would you be able to create an issue for this and add some testing steps?

@dzbaker dzbaker added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Nov 21, 2022
@dzbaker
Copy link
Contributor

dzbaker commented Nov 21, 2022

21 November 2022: Will discuss closing at next CCB due to missing CLA.

@dzbaker dzbaker added CCB:Ignore Pull Request is NOT ready for discussion. Has open actions. Will be re-examined at by next CCB. and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Ignore Pull Request is NOT ready for discussion. Has open actions. Will be re-examined at by next CCB. CCB:PendingCLA community docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants