Integration Candidate 20200108 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #37, Add style configuration
|
Refactored the osal IC branch (no actual content changes) |
|
CCB 20200115 - Reviewed and approved for merge to master |
skliper
added
the
CCB:Approved
chillfig
pushed a commit
to chillfig/cFS
that referenced
this pull request
Mar 17, 2022
The CMD/TLM structures are application-defined. As such, they should not need to depend on compiler-specific extensions like packing. Note that the definitions (mostly) already included explicit spare bytes where padding was likely to be needed, so the "packed" attribute was largely unnecessary here, only serving to make the definitions NOT compilant with C99.
chillfig
pushed a commit
to chillfig/cFS
that referenced
this pull request
Mar 17, 2022
Fix nasa#41, no packing of CMD/TLM structs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Update to IC-20200108
Merge #38
Fix #37
Testing performed
Expected behavior changes
See related pull requests
System(s) tested on
Additional context
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC