Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-3454: Adds UMM-S version to subscription ingest #2

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Conversation

macrouch
Copy link
Contributor

Overview

What is the feature?

The UMM version needs to be added to ingest calls, or CMR will use the latest UMM version, which might be invalid for the payload we send.

What is the Solution?

Add version=<UMM version> to the ingest Content-Type header

What areas of the application does this impact?

Ingesting (creating new) subscriptions

Testing

Reproduction steps

Create a new subscription, ensure successful response

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

Codecov Report

Merging #2 (a952693) into main (2c8fcad) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        43           
  Lines          975       972    -3     
  Branches       140       140           
=========================================
- Hits           975       972    -3     
Impacted Files Coverage Δ
src/utils/cmrIngest.js 100.00% <ø> (ø)
src/cmr/concepts/subscription.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c8fcad...a952693. Read the comment docs.

@macrouch macrouch merged commit 2bcaa89 into main Apr 22, 2022
@macrouch macrouch deleted the EDSC-3454 branch April 22, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants