EDSC-3571: Adds dataloader for collection queries nested under granules #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 45 46 +1
Lines 1008 1063 +55
Branches 141 141
=========================================
+ Hits 1008 1063 +55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…lection concept ids
| @@ -29,7 +33,7 @@ export const ingestSubscription = async (params, headers, parsedInfo) => { | |||
| const subscription = new Subscription(headers, requestInfo, params) | |||
|
|
|||
| // Contact CMR | |||
| await subscription.ingest(params, ingestKeys, headers) | |||
| subscription.ingest(params, ingestKeys, headers) | |||
There was a problem hiding this comment.
trying to understand: why does this not need an await since the ingest method is returning a promise?
` ingest(data, requestedKeys, providedHeaders) {
// eslint-disable-next-line no-param-reassign
data = mergeParams(data)
this.logKeyRequest(requestedKeys, 'ingest')
// Construct the promise that will ingest data into CMR
this.response = cmrIngest(
this.getConceptType(),
data,
providedHeaders,
this.ingestPath
)
}`
There was a problem hiding this comment.
We don't need an await because the methods that use its response await, this was the only external call that had an await so I removed it.
jaybarra
approved these changes
Nov 3, 2022
bademiluyi
approved these changes
Nov 3, 2022
eudoroolivares2016
approved these changes
Nov 3, 2022
| const result = await dataSources.variableSource(args, headers, parseResolveInfo(info)) | ||
| variables: async (source, args, context, info) => { | ||
| const { dataSources } = context | ||
|
|
abbottry
approved these changes
Nov 3, 2022
abbottry
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.