EDSC-3587: Ensures a Client-Id is always sent for external request #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 49 49
Lines 1087 1098 +11
Branches 141 141
=========================================
+ Hits 1087 1098 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
macrouch
approved these changes
Dec 16, 2022
trevorlang
approved these changes
Dec 16, 2022
| @@ -31,6 +31,18 @@ export default class CollectionDraft extends Concept { | |||
| ] | |||
| } | |||
|
|
|||
| /** | |||
| * Retrieve the request id header from the request | |||
| * @param {Object} headers The provided headers from the query | |||
There was a problem hiding this comment.
We might want a @return {string} declaration here as well
| @@ -31,6 +31,18 @@ export default class CollectionDraftProposal extends Concept { | |||
| ] | |||
| } | |||
|
|
|||
| /** | |||
| * Retrieve the request id header from the request | |||
| * @param {Object} headers The provided headers from the query | |||
There was a problem hiding this comment.
Same comment re: @return
| @@ -295,6 +295,18 @@ export default class Concept { | |||
| return requestId | |||
| } | |||
|
|
|||
| /** | |||
| * Retrieve the client id header from the request | |||
| * @param {Object} headers The provided headers from the query | |||
There was a problem hiding this comment.
Same comment re: @return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to create more visibility into the usage of graphql and its place as a proxy between many applications and CMR, this PR increases the usage, including an always sent default,
Client-Idheader.