-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MMT-2863: Added Standard Product #6
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 43 43
Lines 978 978
Branches 146 146
=========================================
Hits 978 978
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to ask CMR for the newest version of UMM-C as StandardProduct is only available there, that version is 1.17.0 -- this update needs to happen in serverless.yml. There is an additional issue found while testing that fails for records that have false
as their value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GraphQL is currently using UMM-C v1.16.4, StandardProduct was added in v1.17.0. You need to update serverless.yml line #21 ummCollectionVersion
to be '1.17.0'.
I also found a small bug that is causing a false
value to be returned as null
. src/cmr/concepts/concept.js line #638 should be
if (keyValue != null) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added StandardProduct to CollectionDraft and CollectionDraftProposal.
Added StandardProduct to CollectionDraft and CollectionDraftProposal.
Added Standard Product