Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMT-2863: Added Standard Product #6

Merged
merged 8 commits into from
May 13, 2022
Merged

MMT-2863: Added Standard Product #6

merged 8 commits into from
May 13, 2022

Conversation

dmistry1
Copy link
Contributor

Added Standard Product

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Merging #6 (1408dc9) into main (7aa2fbe) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        43           
  Lines          978       978           
  Branches       146       146           
=========================================
  Hits           978       978           
Impacted Files Coverage Δ
src/cmr/concepts/concept.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa2fbe...1408dc9. Read the comment docs.

Copy link
Member

@abbottry abbottry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to ask CMR for the newest version of UMM-C as StandardProduct is only available there, that version is 1.17.0 -- this update needs to happen in serverless.yml. There is an additional issue found while testing that fails for records that have false as their value.

Copy link
Contributor

@macrouch macrouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GraphQL is currently using UMM-C v1.16.4, StandardProduct was added in v1.17.0. You need to update serverless.yml line #21 ummCollectionVersion to be '1.17.0'.

I also found a small bug that is causing a false value to be returned as null. src/cmr/concepts/concept.js line #638 should be

    if (keyValue != null) {

Copy link
Contributor

@trevorlang trevorlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve when the comments from @macrouch and @abbottry are addressed

dmistry2 added 4 commits May 12, 2022 13:20
Added StandardProduct to CollectionDraft and CollectionDraftProposal.
Added StandardProduct to CollectionDraft and CollectionDraftProposal.
@macrouch macrouch merged commit 06bf50b into nasa:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants