Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-9090: Add support for UMM-S to CMR graphql #62

Merged
merged 6 commits into from
Sep 1, 2023
Merged

Conversation

dmistry1
Copy link
Contributor

Overview

What is the feature?

Added Support for UMM-S draft preview. Also updated the UMM-S field to the latest UMM-S version 1.5.1

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #62 (e013236) into MMT-3382 (d89ade4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           MMT-3382       #62   +/-   ##
==========================================
  Coverage    100.00%   100.00%           
==========================================
  Files            61        63    +2     
  Lines          1270      1282   +12     
  Branches        162       162           
==========================================
+ Hits           1270      1282   +12     
Files Changed Coverage Δ
src/resolvers/index.js 100.00% <ø> (ø)
src/datasources/serviceDraft.js 100.00% <100.00%> (ø)
src/resolvers/serviceDraft.js 100.00% <100.00%> (ø)

type Query {
serviceDraft (
params: ServiceDraftInput
): ServiceDraft
Copy link
Contributor

@eudoroolivares2016 eudoroolivares2016 Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline at the end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

.defaultReplyHeaders({
'X-Request-Id': 'abcd-1234-efgh-5678'
})
.get(/api\/tool_drafts/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.get(/api\/tool_drafts/)
.get(/api\/service_drafts/)

this one meant to be tool?

@dmistry1 dmistry1 merged commit 5736bec into MMT-3382 Sep 1, 2023
7 checks passed
@dmistry1 dmistry1 deleted the CMR-9090 branch September 1, 2023 14:34
dmistry1 added a commit that referenced this pull request Oct 17, 2023
* CMR-9090: Add support for UMM-S to CMR graphql (#62)

* CMR-9090: Added support for Service Draft.

* CMR-9090: Added test cases for serviceDraft

* CMR-9090: Updated UMM-S version

* CMR-9090: Reflected on PR comments

* CMR-9090: Fixed the serviceDraft test

* MMT-3382: Fixed lint warnings

* MMT-3382: Updated the latest service fields
dmistry1 added a commit that referenced this pull request Oct 23, 2023
* CMR-9090: Add support for UMM-S to CMR graphql (#62)

* CMR-9090: Added support for Service Draft.

* CMR-9090: Added test cases for serviceDraft

* CMR-9090: Updated UMM-S version

* CMR-9090: Reflected on PR comments

* CMR-9090: Fixed the serviceDraft test

* MMT-3382: Fixed lint warnings

* MMT-3382: Updated the latest service fields

* MMT-3382: Added missing Service Publish fields

* MMT-3382: Fixed accessConstraints and Quality
dmistry1 added a commit that referenced this pull request Oct 24, 2023
* CMR-9090: Add support for UMM-S to CMR graphql (#62)

* CMR-9090: Added support for Service Draft.

* CMR-9090: Added test cases for serviceDraft

* CMR-9090: Updated UMM-S version

* CMR-9090: Reflected on PR comments

* CMR-9090: Fixed the serviceDraft test

* MMT-3382: Fixed lint warnings

* MMT-3382: Updated the latest service fields

* MMT-3382: Added missing Service Publish fields

* MMT-3382: Fixed accessConstraints and Quality

* MMT-3382: Added missing fields

* MMT-3408: Adds mutations and queries for draft concepts

* MMT-3408: Updated field documentation, fixed params

* MMT-3408: Adds ummMetadata field to return raw metadata, pr comments

* MMT-3408: Better test URLs, throw error when required field is missing, add util to check for draft concept ids

---------

Co-authored-by: Matthew Crouch <matthew@element84.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants