Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-3817: Adding variables to services #64

Merged
merged 4 commits into from
Sep 8, 2023
Merged

EDSC-3817: Adding variables to services #64

merged 4 commits into from
Sep 8, 2023

Conversation

dpesall
Copy link
Member

@dpesall dpesall commented Sep 1, 2023

Overview

What is the feature?

Adding variable associations to services.

What areas of the application does this impact?

Service to Variable associations

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #64 (c1136a1) into main (d89ade4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #64   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           61        61           
  Lines         1270      1279    +9     
  Branches       162       165    +3     
=========================================
+ Hits          1270      1279    +9     
Files Changed Coverage Δ
src/resolvers/service.js 100.00% <100.00%> (ø)

@dpesall dpesall merged commit ca0e296 into main Sep 8, 2023
7 checks passed
@dpesall dpesall deleted the EDSC-3817 branch September 8, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants