-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDSC-3844 Implement @edsc/eslint-config in cmr-graphql #66
Conversation
Codecov Report
@@ Coverage Diff @@
## main #66 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 61 61
Lines 1279 1278 -1
Branches 165 165
=========================================
- Hits 1279 1278 -1
|
README.md
Outdated
npm install | ||
npm install | ||
|
||
To install the edsc shared lint configuration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step isn't necessary, it is included in the repo now and is covered by npm install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the README change @macrouch suggested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The max-len warnings in graphDb.test.js are annoying for the regex lines. I think we need to update the eslint config repo to ignore regex https://eslint.org/docs/latest/rules/max-len#ignoreregexpliterals
After we update that repo and deploy a new version of the npm package, and update that package here, those warnings should go away
a52ebb8
to
efacf7c
Compare
Overview
What is the feature?
Changes linter config
What is the Solution?
We not use shared config @edsc
What areas of the application does this impact?
N/A
Checklist