Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-3844 moves eslint deps into dependencies #67

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

daniel-zamora
Copy link
Contributor

@daniel-zamora daniel-zamora commented Sep 15, 2023

Overview

What is the feature?

Deployment is being blocked by dependency related issues caused by eslint config changes.

What is the Solution?

Move eslint deps out of dev dependencies and into dependencies.

What areas of the application does this impact?

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #67 (7089518) into main (6b5c4e6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #67   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           61        61           
  Lines         1278      1278           
  Branches       165       165           
=========================================
  Hits          1278      1278           

@daniel-zamora daniel-zamora merged commit 5e7993d into main Sep 15, 2023
7 checks passed
@daniel-zamora daniel-zamora deleted the EDSC-3844-2 branch September 15, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants