Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CUMULUS-2271 Allow horizontal scrolling on table columns #897

Merged
merged 6 commits into from Dec 2, 2020
Merged

CUMULUS-2271 Allow horizontal scrolling on table columns #897

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e624fa4
CUMULUS-2271 set overflow on table columns
npauzenga Dec 1, 2020
e6ad34b
CUMULUS-2271 update changelog
npauzenga Dec 1, 2020
ae3656f
CUMULUS-2271 allow scrollbar to expand table rows on hover
npauzenga Dec 1, 2020
d64f74d
Merge branch 'develop' into feature/CUMULUS-2271-table-horizontal-scroll
npauzenga Dec 2, 2020
6c147fa
CUMULUS-2271 fix changelog formatting
npauzenga Dec 2, 2020
7525730
CUMULUS-2271 force horizontal scrollbar to render on tables
npauzenga Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -40,6 +40,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
**CUMULUS-2242**
- Changes underlying Docker files for building dashboard bundle and dashboard image via docker. The user interface remains the same.

- **CUMULUS-2271**
- Allow horizontal scrolling in table cells when content doesn't fit in view

## [v3.0.0]

### Fixed
Expand Down
8 changes: 4 additions & 4 deletions app/src/css/modules/_table.scss
View file
Open in desktop
Expand Up @@ -34,10 +34,10 @@
padding: 1em 2em;
vertical-align: middle;
overflow: hidden;
text-overflow: ellipsis;
/*&:first-of-type {
padding: 1em 0 1em 2em;
}*/
min-height: 65px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might not need to add a min-height here if we don't want to. I have it because without it the row will expand vertically when hovered to fit the scrollbar. It does increase all of the row heights though. If we remove it the row will expand on hover, which also might not be terrible. I could go either way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@npauzenga I'm curious what the second option would look like with expand on hover.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjmccoy yeah, if you comment out this line (37) and hover over the table cells, they will expand to fit the scrollbar. Happy to jump on a screenshare if that's helpful.

&:hover {
overflow: auto;
}
}
.table__main-asset {
font-weight: $base-font-semibold;
Expand Down