Allow braces in log messages #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re given
* this allows the user more freedom in what is in their logging and error
strings, including JSON strings plus additional text about the JSON; with
the previous behavior, `createMessage` raises an `IndexError` or
`KeyError` if the log (or error) message has any curly braces in it but no
args/kwargs due to the `str.format` call
* fix the new unit tests added in 34ede6d
michaeljb
commented
Nov 3, 2021
| self.assertTrue(logger.logger.getEffectiveLevel() == logging.INFO) | ||
| logger.debug("test logging level debug") | ||
| logger.info("test logging level info") | ||
| logger.warning("test logging level warning") | ||
|
|
||
| def test_simple_message_with_braces_no_args(self): |
There was a problem hiding this comment.
I committed these new tests in 34ede6d before committing the fix; to see the failing behavior:
git checkout 34ede6d
nosetests tests/test_logger.py
michaeljb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add some failing tests for new behavior
DRY out other tests with helper function
in
CumulusLogger.createMessage, callstr.formatiff args/kwargs are givenincluding JSON strings plus additional text about the JSON; with the previous
behavior,
createMessageraises anIndexErrororKeyErrorif the log (orerror) message has any curly braces in it but no args/kwargs due to the
str.formatcall[Fixes #38]