Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures, extract common hypothesis givens #101

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

lpsinger
Copy link
Contributor

Fixes the following error from hypothesis in the unit tests on macOS:

FAILED dorado/scheduling/tests/test_earth_limb.py::test_observer_on_surface - FloatingPointError: Got allow_subnormal=True, but we can't represent subnormal floats right now, in violation of the IEEE-754 floating-point specification.  This is usually because something was compiled with -ffast-math or a similar option, which sets global processor state.  See https://simonbyrne.github.io/notes/fastmath/ for a more detailed writeup - and good luck!

Fixes the following error from hypothesis in the unit tests on macOS:

```
FAILED dorado/scheduling/tests/test_earth_limb.py::test_observer_on_surface - FloatingPointError: Got allow_subnormal=True, but we can't represent subnormal floats right now, in violation of the IEEE-754 floating-point specification.  This is usually because something was compiled with -ffast-math or a similar option, which sets global processor state.  See https://simonbyrne.github.io/notes/fastmath/ for a more detailed writeup - and good luck!
```
@lpsinger lpsinger merged commit aefdca6 into nasa:main Apr 17, 2024
6 of 7 checks passed
@lpsinger lpsinger deleted the fix-hypothesis-subnormal-error branch April 17, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant