Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call KNe light curves from gwemlightcurves #37

Merged
merged 2 commits into from
Apr 17, 2021
Merged

Conversation

mcoughlin
Copy link
Collaborator

Can use KNe function from gwemlightcurves to produce lightcurves.

Fixes #33 .

@codecov
Copy link

codecov bot commented Apr 17, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@1eb60ed). Click here to learn what that means.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #37   +/-   ##
=========================================
  Coverage          ?   21.45%           
=========================================
  Files             ?       25           
  Lines             ?     1622           
  Branches          ?        0           
=========================================
  Hits              ?      348           
  Misses            ?     1274           
  Partials          ?        0           
Impacted Files Coverage Δ
dorado/scheduling/metrics/kne.py 18.88% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eb60ed...127f457. Read the comment docs.

@mcoughlin
Copy link
Collaborator Author

Unit tests pass. Merging.

@mcoughlin mcoughlin merged commit 9098ad3 into nasa:master Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depend on or vendor code for kne.py
1 participant