Add tiling example #5
Conversation
| @@ -137,7 +137,7 @@ To install with [Pip]: | |||
| 5. To generate an animated visualization for this observing plan, run the | |||
| following command: | |||
|
|
|||
| $ dorado-scheduling-animate exaples/6.fits examples/6.ecsv examples/6.gif | |||
| $ dorado-scheduling-animate examples/6.fits examples/6.ecsv examples/6.gif | |||
There was a problem hiding this comment.
Good catch! I just fixed that on master, so please rebase.
| return p | ||
|
|
||
| def tesselation_spiral(FOV_size, scale=0.80): | ||
| FOV = FOV_size*FOV_size*scale |
There was a problem hiding this comment.
Please fix these lint errors.
dorado/scheduling/scripts/tile.py
Outdated
| points = np.zeros((n, 3)) | ||
| points[:,0] = radius * np.cos(theta) | ||
| points[:,1] = radius * np.sin(theta) | ||
| points[:,2] = z | ||
|
|
||
| ra, dec = hp.pixelfunc.vec2ang(points, lonlat=True) | ||
| return ra, dec |
There was a problem hiding this comment.
| points = np.zeros((n, 3)) | |
| points[:,0] = radius * np.cos(theta) | |
| points[:,1] = radius * np.sin(theta) | |
| points[:,2] = z | |
| ra, dec = hp.pixelfunc.vec2ang(points, lonlat=True) | |
| return ra, dec | |
| coords = SkyCoord(radius, theta * u.rad, z, representation_type='cylindrical') | |
| coords.representation_type = 'unitspherical' | |
| return coords |
|
Would you mind plotting the output of this please, to check? |
Co-authored-by: Leo Singer <leo.singer@ligo.org>
Co-authored-by: Leo Singer <leo.singer@ligo.org>
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
=======================================
Coverage 89.70% 89.70%
=======================================
Files 6 6
Lines 136 136
=======================================
Hits 122 122
Misses 14 14 Continue to review full report at Codecov.
|
|
Here's what this looks like near the north celestial pole. It has a lot of overlap. Does this look correct?
|
|
Yeah I just added one that I think behaves a bit better at the poles. Can we add that script to tiles.py for the plotting? |
|
What is the provenance of these algorithms? Have they been used for previous surveys? |
|
I have used a variation on these to produce tilings for various telescopes, including DECam and others. I usually tune the overlaps by hand a bit for the various surveys to get some reasonable amount of overlap, which also means needing to play around a bit close to the poles. |
|
Would you please add docstrings with references to the journal articles where these grids are introduced, described, or used? |
dorado/scheduling/scripts/tile.py
Outdated
| return coords | ||
|
|
||
|
|
||
| def tesselation_packing(FOV_size, scale=0.97): |
There was a problem hiding this comment.
This is a pretty generic name.
|
I'm ready to merge this as soon as legal processes your CLA. So sorry about the red tape. |
|
I added geodesic grids: https://dorado-scheduling.readthedocs.io/en/latest/reference/tesselation.html |
|
awesome leo! |
|
They finally got your CLA processed. I'd like to see this unified with the new |
|
Let's get this merged and then I can help as necessary this weekend when I have more time. Thanks Leo. |
Quick example to make a tiling on the sphere