Updating UVEX TLE #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpsinger
requested changes
Jun 14, 2021
Codecov Report
@@ Coverage Diff @@
## main #71 +/- ##
==========================================
- Coverage 30.36% 29.83% -0.54%
==========================================
Files 35 35
Lines 1683 1713 +30
==========================================
Hits 511 511
- Misses 1172 1202 +30
Continue to review full report at Codecov.
|
|
Waiting on workflow approval to rerun checks |
lpsinger
requested changes
Jun 14, 2021
lpsinger
requested changes
Jun 15, 2021
Have not adjusted the EarthLimbConstraint in the spirit of only changing one thing at a time. LINT fixes lint again Rewording comments lint nazi
|
Unit tests pass! |
|
I'm really sorry, but I have to revert this because we haven't gotten @bwgref's CLA yet. Ughhh... lawyers. |
|
So we should be using this TLE locally for now, otherwise the science teams are building search efficiencies off of unrealistic schedules no? |
|
I think we just need someone who has a signed CLA to provide the TLE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have not adjusted the EarthLimbConstraint in the spirit of only changing one thing at a time.