Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #91, Redo SymbolNames malloc to remove out-of-bounds write #122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #91, Redo SymbolNames malloc to remove out-of-bounds write #122

wants to merge 1 commit into from

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Oct 28, 2022 •
edited
Loading

Checklist

Describe the contribution

Testing performed
Just GitHub CI Actions so far.

Expected behavior changes
Logic stays the same, but the possibility of an out-of-bounds write is removed.

Contributor Info
Avi Weiss @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-91-remove-outofbounds-write-from-SymbolNames-malloc branch from de20b36 to eef7cf8 Compare October 28, 2022 19:22
@dzbaker dzbaker requested a review from chillfig November 3, 2022 18:37
@dzbaker dzbaker added this to the Fornax milestone Nov 21, 2022
@dzbaker dzbaker modified the milestones: Fornax, Equuleus Dec 7, 2022
jphickey
jphickey requested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem right ... where did the call to fgetc() go?

I also don't see a buffer overrun in the original. It may write to the last char, but that's OK, as it ensures its got a null term afterward. Doesn't seem like the original code was broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jphickey jphickey jphickey requested changes

@chillfig chillfig chillfig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Equuleus
Development

Successfully merging this pull request may close these issues.

Out-of-bounds Write for VerboseStr
4 participants
@thnkslprpt @jphickey @chillfig @dzbaker