-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Out-of-bounds Write for VerboseStr #91
Comments
Hi, I would like to work on this issue. Can you guide me further on what needs ti be done ^_^ |
@himanshu007-creator - I haven't reviewed all the code, but likely could remove the while loop all together and just set the last character as '\0' and use strlen to size the stored symbol name. Something like:
Then you can likely also remove |
Describe the bug
Bad while loop causing out-of-bounds write
Expected behavior
Fix while loop
Code snips
elf2cfetbl/elf2cfetbl.c
Lines 1927 to 1932 in 10f55fb
System observed on:
Coverity: https://scan.coverity.com/projects/arielsadamsnasa-cfs-jsf-rules?tab=overview
Additional context
Checking i < 60UL implies that i is 60 on the false branch.
Overrunning array VerboseStr of 60 bytes at byte offset 60 using index i (which evaluates to 60).
Reporter Info
Ariel Adams, ASRC Federal
The text was updated successfully, but these errors were encountered: