Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise release script #181

Merged
merged 15 commits into from Nov 3, 2022
Merged

Revise release script #181

merged 15 commits into from Nov 3, 2022

Conversation

bocchino
Copy link
Collaborator

@bocchino bocchino commented Oct 29, 2022

  • Improve diagnostic messages.
  • Improve validation of release archive. Use diff instead of size estimate to check correctness.
  • Revise the directory structure in the release archive. On my Mac, I noticed that we were giving absolute paths starting with / to tar. But these paths are meaningless in a release tar ball. My Mac was warning about it.
  • Bump the GraalVM version to 22.3.0. This also fixes the problem with the missing trace info.
  • In GraalVM 22.3.0, the trace info that we added by hand caused a warning, so I deleted it.
  • Delete the code that runs all the JVM unit tests and captures the trace. Since we are checking the trace into the repo, and it seems brittle to changes in FPP and/or GraalVM, the procedure will be to run the trace manually, verify that everything is working, and commit any changes to the trace before submitting a release to GitHub.
  • Revert the GraalVM README to what we had in the previous release. Hopefully, with the latest GraalVM, we won't have to hand-edit trace files.
  • Use gtar instead of tar on Mac OS -- tar does not work properly.
  • Switch from ubuntu-latest to ubuntu-18.04 for compatibility.
  • Add and document an FPP_NATIVE_IMAGE_FLAGS configuration variable.

@bocchino
Copy link
Collaborator Author

The archive creation failure appears to be a known issue with the Mac OS virtual environment. See actions/runner-images#2619.

@bocchino
Copy link
Collaborator Author

The archive creation failure appears to be a known issue with the Mac OS virtual environment.

Attempting to fix by using gtar if available.

@bocchino
Copy link
Collaborator Author

I successfully got release v1.1.0a6 through the GitHub build process. Whew!

https://github.com/fprime-community/fpp/releases/tag/v1.1.0a6

@tiffany1618 This release should be good to test with. I used it to build F Prime on your branch.

@LeStarch
Copy link
Collaborator

@bocchino we should switch the runner to ubuntu-18.04 for similar reasons to using the latest macOS. In the long-term I do not think this method of distributing FPP is sustainable as the runners to build these tools are deprecating faster than the platforms we need to support.

@LeStarch
Copy link
Collaborator

Note: building on 18.04 has kernel version 4.15 which is old enough for our Redhat customers.

@LeStarch
Copy link
Collaborator

LeStarch commented Nov 1, 2022

@bocchino also, why not bump to 22.3.0?

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments. Nothing blocking.

compiler/release Show resolved Hide resolved
.github/workflows/env-setup Outdated Show resolved Hide resolved
.github/workflows/build-native.yml Outdated Show resolved Hide resolved
@LeStarch
Copy link
Collaborator

LeStarch commented Nov 1, 2022

I might also add an argument for extra native-image flags. For example, the issue I was seeing on the redhat was /tmp was mounted as noexec. Thus I needed to supply an alternative /tmp using -H:TempDirectory=/path/to/something/executable.

Add FPP_NATIVE_IMAGE_FLAGS
Update README
@bocchino
Copy link
Collaborator Author

bocchino commented Nov 1, 2022

I might also add an argument for extra native-image flags.

Done.

@LeStarch
Copy link
Collaborator

LeStarch commented Nov 1, 2022

I ran on 22.3.0 last night and everything went fine.

@bocchino bocchino merged commit c7c6e68 into main Nov 3, 2022
@bocchino bocchino deleted the release branch November 3, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants