New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise release script #181
Conversation
bocchino
commented
Oct 29, 2022
•
edited
edited
- Improve diagnostic messages.
- Improve validation of release archive. Use diff instead of size estimate to check correctness.
- Revise the directory structure in the release archive. On my Mac, I noticed that we were giving absolute paths starting with / to tar. But these paths are meaningless in a release tar ball. My Mac was warning about it.
- Bump the GraalVM version to 22.3.0. This also fixes the problem with the missing trace info.
- In GraalVM 22.3.0, the trace info that we added by hand caused a warning, so I deleted it.
- Delete the code that runs all the JVM unit tests and captures the trace. Since we are checking the trace into the repo, and it seems brittle to changes in FPP and/or GraalVM, the procedure will be to run the trace manually, verify that everything is working, and commit any changes to the trace before submitting a release to GitHub.
- Revert the GraalVM README to what we had in the previous release. Hopefully, with the latest GraalVM, we won't have to hand-edit trace files.
- Use gtar instead of tar on Mac OS -- tar does not work properly.
- Switch from ubuntu-latest to ubuntu-18.04 for compatibility.
- Add and document an FPP_NATIVE_IMAGE_FLAGS configuration variable.
It looks like they fixed the issue of the missing trace info
The archive creation failure appears to be a known issue with the Mac OS virtual environment. See actions/runner-images#2619. |
Attempting to fix by using gtar if available. |
I successfully got release v1.1.0a6 through the GitHub build process. Whew! https://github.com/fprime-community/fpp/releases/tag/v1.1.0a6 @tiffany1618 This release should be good to test with. I used it to build F Prime on your branch. |
@bocchino we should switch the runner to |
Note: building on 18.04 has kernel version 4.15 which is old enough for our Redhat customers. |
@bocchino also, why not bump to 22.3.0? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments. Nothing blocking.
I might also add an argument for extra |
Add FPP_NATIVE_IMAGE_FLAGS Update README
Done. |
Use oldest available versions, for compatibility
I ran on 22.3.0 last night and everything went fine. |