Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise string interfaces for dictionary elements #409

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

bocchino
Copy link
Collaborator

Closes #407. See that issue for the rationale.

Notes:

  • This PR incorporates changes from Fix C++ code gen for string records #408. Merge that one before reviewing.
  • This PR will require some minor changes to user test code. For example, you can no longer pass a bare char* to the sendCmd interface; you have to wrap your char* in an F Prime string constructor. However, I think we want to go in this direction. We should avoid implicit conversions, e.g., implicitly converting char* to an F Prime string type. Eventually, if possible, we should make single-argument constructors explicit.

@bocchino bocchino requested a review from LeStarch April 18, 2024 00:29
@bocchino bocchino merged commit 2a2fde6 into main Apr 25, 2024
11 checks passed
@bocchino bocchino deleted the issue-407-dictionary-strings branch April 25, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove TlmString, LogString, etc. from generated interface
2 participants