Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consistency to imports based on isort settings #130

Merged
merged 1 commit into from
May 17, 2023

Conversation

ThibFrgsGmz
Copy link
Contributor

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

This PR consists of de-duplicating, grouping and sorting imports according to isort parameters.

Rationale

This is to make the code base more consistent, as using a common convention for imports makes the code more readable and idiomatic.

Ref - Ruff linter

Testing/Review Recommendations

Visual inspection

Future Work

Add Ruff linter into repo's CI (WIP).

@ThibFrgsGmz ThibFrgsGmz changed the title Add consistency to imports base on isort settings Add consistency to imports based on isort settings May 12, 2023
Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual inspection. LGTM.

Out of curiosity, was this automatically modified by running Ruff locally?

@ThibFrgsGmz
Copy link
Contributor Author

Visual inspection. LGTM.

Out of curiosity, was this automatically modified by running Ruff locally?

Yes, hope this tool to be integrated soon ! I did not linked my other PR in this ticket.

@thomas-bc thomas-bc merged commit ca2c9c7 into nasa:devel May 17, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants