Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to accept comms with FSW running TCP server #137

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

thomas-bc
Copy link
Collaborator

@thomas-bc thomas-bc commented Aug 10, 2023

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Add a command line option to have the GDS comms adapter act as a client instead of server, thus accepting FSW acting as the TCP server. I wasn't sure what the best --option-name and help_text were... let me know if you have a better idea.

Testing/Review Recommendations

With the option, server=False is fed into the constructor here:

https://github.com/thomas-bc/fprime-gds/blob/96dd25f02f727ada49ce99160f8b198fe78bb271/src/fprime_gds/common/communication/adapters/base.py#L117-L118

@thomas-bc
Copy link
Collaborator Author

thomas-bc commented Aug 10, 2023

I have confirmed that this works with the following deployment: thomas-bc/sample-fprime-project@main...gds-as-client

Running on a remote RaspberryPi, looks like the following

# on the RPI
./SampleDeployment -a 0.0.0.0 -p 50000
# on the ground
fprime-gds -n --ip-client --ip-address <RPI_ADDRESS> --dictionary <path/to/dict.xml>

@LeStarch LeStarch merged commit a0807c7 into nasa:devel Aug 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants