Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output unframed (garbage) data to file #151

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

LeStarch
Copy link
Collaborator

@LeStarch LeStarch commented Nov 17, 2023

Originating Project/Creator Infra
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

This introduces a new argument --output-unframed-data to the fprime-gds that allows capture and output of the unframed (junk) data that is discarded by the deframing process. This is needed for several reasons:

  1. Sometimes data is multi-plexed, that is, frames come down mixed with something else (like console data)
  2. Sometimes this data is necessary to understand bugs and other issues
  3. Sometimes no data loss is acceptable even-if corrupted

This option allows users to output it when the flag is supplied. When not supplied, the data is discarded as it was previously.

Fixed some other issues:

  1. Logs drop-down jumping about: Log Dropdown Jumps About fprime#2381
  2. Logs pane clearing current data when erred preventing user from seeing what was there: Stop Clearing Log Pane Output on Shutdown fprime#2380
  3. Better scrolling of log pane data. Fixes: GDS Log Scrolling fprime#2379
  4. Python log output in GDS is no-longer in triplicate. Fixes: GDS Logs in Triplicate fprime#2378

Primarily fixes: nasa/fprime#2382

Rationale

See above.

Testing/Review Recommendations

Tested by putting out-of-frame data into Ref's downlink.

Future Work

None

src/fprime_gds/executables/comm.py Dismissed Show resolved Hide resolved
thomas-bc
thomas-bc previously approved these changes Nov 21, 2023
Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Looks good to me

src/fprime_gds/flask/static/js/vue-support/log.js Outdated Show resolved Hide resolved
@LeStarch
Copy link
Collaborator Author

Fixed. See screenshot:
error

@LeStarch LeStarch merged commit 54532c8 into nasa:devel Nov 27, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants