Add pyproject.toml #153
Merged
Add pyproject.toml #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeStarch
reviewed
Dec 7, 2023
| "Programming Language :: Python :: 3.8", | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", |
There was a problem hiding this comment.
Should we add Py 12 back?
There was a problem hiding this comment.
Yes let's! will add to other PRs as well
| fprime-gds = "fprime_gds.executables.run_deployment:main" | ||
|
|
||
| # For Pytest fixtures | ||
| [project.entry-points."pytest11"] |
There was a problem hiding this comment.
Why is pytest11 in quotes here?
There was a problem hiding this comment.
It seems to be the notation https://setuptools.pypa.io/en/latest/userguide/entry_point.html#entry-points-for-plugins
I'm guessing it's because it's user-defined (in the plugin) and not part of the standard template or some other terminology
LeStarch
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
pyproject.tomlRationale
Conform to PEP517, 518 et al. Modernize our Python setup so as not to be left behind. Potentially help with Python 3.12 support
Testing/Review Recommendations
TODO: