Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command argument types when importing from history #159

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

thomas-bc
Copy link
Collaborator

@thomas-bc thomas-bc commented Jan 19, 2024

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Fix nasa/fprime#2473

Converting command arguments to string if available (e.g. on int's) as the command input fields expects them to be strings.

@thomas-bc thomas-bc requested review from LeStarch and removed request for LeStarch January 19, 2024 19:36
@thomas-bc
Copy link
Collaborator Author

Oops - this is causing issues with complex commanding - looking into it

@thomas-bc
Copy link
Collaborator Author

Tested with complex commanding from fprime/Ref/TypeDemo

@LeStarch LeStarch merged commit a4077c2 into nasa:devel Jan 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F Prime GDS - Commanding locks up when resending a command from the history.
2 participants