Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #21 Event scroll bottom issue #22

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Fixes #21 Event scroll bottom issue #22

merged 2 commits into from
Aug 18, 2021

Conversation

saba-ja
Copy link
Contributor

@saba-ja saba-ja commented Aug 15, 2021

Originating Project/Creator F' GDS 2.0
Affected Component event.js
Affected Architectures(s) NA
Related Issue(s) #21
Has Unit Tests (y/n) No
Builds Without Errors (y/n) Y
Unit Tests Pass (y/n) NA
Documentation Included (y/n) N

Change Description

On systems using display scaling, scrollTop may give you a decimal value.

Reference MDN scrollTop

To resolve the scroll issue added 2.0 px tolerance.

Rationale

Since some browsers return sub-pixel values cannot use exact integer number to detect the location of scroll bar.

Testing/Review Recommendations

Manually verified the fix on both Mac and Pc on Chrome 92.0.4515.131 and FireFox 91.0

Future Work

NA

@LeStarch LeStarch merged commit bf4dd30 into nasa:devel Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants