Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for fprime-cli #60

Merged
merged 3 commits into from
Jun 16, 2022
Merged

Fixes for fprime-cli #60

merged 3 commits into from
Jun 16, 2022

Conversation

codeflight1
Copy link
Contributor

Originating Project/Creator
Affected Component fprime-cli
Affected Architectures(s)
Related Issue(s) nasa/fprime#1443
Has Unit Tests (y/n) y
Builds Without Errors (y/n) y
Unit Tests Pass (y/n) y
Documentation Included (y/n)

Change Description

Adds default dictionary search to fprime-cli and fixes channel display bug.

Future Work

nasa/fprime#1443 points 3 and 4 still need to be addressed.

@codeflight1 codeflight1 mentioned this pull request May 31, 2022
Closed
@codeflight1 codeflight1 mentioned this pull request Jun 16, 2022
Closed
LeStarch
LeStarch approved these changes Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@LeStarch
Copy link
Collaborator

Closing, reopening, attempting to fix CI

@LeStarch LeStarch closed this Jun 16, 2022
@LeStarch LeStarch reopened this Jun 16, 2022
@LeStarch LeStarch merged commit 97f5492 into nasa:devel Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeStarch LeStarch LeStarch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codeflight1 @LeStarch