Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BaseAdapter.process_arguments with dict-comprehension #61

Merged
merged 1 commit into from
May 31, 2022
Merged

Refactor BaseAdapter.process_arguments with dict-comprehension #61

merged 1 commit into from
May 31, 2022

Conversation

ThibFrgsGmz
Copy link
Contributor

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s) void
Has Unit Tests (y/n) n
Builds Without Errors (y/n) Let CI run
Unit Tests Pass (y/n) Let CI run
Documentation Included (y/n) n

Change Description

This PR contains the following changes:

  1. Refactoring BaseAdapter.process_arguments with dictionary comprehension

Rationale

Dictionary comprehensions allows to create the dictionary on a single line, which avoids declaring an empty dict and then adding elements.
Comprehensions generally run faster than building the collection in a loop, which is another factor if performance is an important consideration.

Testing/Review Recommendations

void

Future Work

void

@LeStarch LeStarch merged commit 9abdc61 into nasa:devel May 31, 2022
@ThibFrgsGmz ThibFrgsGmz deleted the feat/dict_comp_base-adapter_proc-arg branch August 19, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants