Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace LGTM with Github Actions #101

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

thomas-bc
Copy link
Contributor

Originating Project/Creator
Affected Component
Affected Architectures(s) Github Actions
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Adds a Github Actions workflow that runs the security and quality static code analysis in order to phase LGTM out.

Rationale

lgtm.com will be shut down at the end of the year.

Future Work

Remove the LGTM configuration files once it's fully shut down.

Comments

Results should be viewable once the checks are done. It's currently running all queries from the security-and-quality suite, let me know if we want to filter some categories out.

@LeStarch
Copy link
Collaborator

LeStarch commented Nov 3, 2022

@thomas-bc can you add these words to .github/actions/spelling/expect.txt? This is how to fix the spelling issues. I found these in the spelling action log:


configs
deserializes
funcs
toolchains

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. It is catching issues already...

@LeStarch LeStarch merged commit 29cb995 into nasa:devel Nov 7, 2022
@thomas-bc thomas-bc deleted the workflow/gh-code-scan branch October 11, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants