Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGTM is deprecated. #102

Merged
merged 1 commit into from
Nov 8, 2022
Merged

LGTM is deprecated. #102

merged 1 commit into from
Nov 8, 2022

Conversation

LeStarch
Copy link
Collaborator

@LeStarch LeStarch commented Nov 7, 2022

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Now that we have code ql, this will remove the LGTM config file.

Copy link
Contributor

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the config file sounds good to me. An admin may have to disable the LGTM integration, as it looks like this PR is still looking for the LGTM check. Directions to disable the integration can be found here - I think what we're looking for is "Uninstall LGTM" option.

@LeStarch LeStarch merged commit b12d613 into devel Nov 8, 2022
@LeStarch
Copy link
Collaborator Author

LeStarch commented Nov 8, 2022

@thomas-bc I have uninstalled LGTM on both this and fprime-gds repos.

@thomas-bc thomas-bc deleted the update/lgtm-no-more branch July 12, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants