Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper bounds on dependency requirements #114

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

thomas-bc
Copy link
Contributor

@thomas-bc thomas-bc commented Jan 30, 2023

Originating Project/Creator
Affected Component
Affected Architectures(s) setup.py
Related Issue(s) nasa/fprime#1690
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Removing the upper bounds on dependency requirements in the setup.py in preparation for version bumps in F' core requirements.txt

Rationale

Python package versions need bumping as some are insecure. This will be done in the requirements.txt in F', but we need to loosen the requirements on fprime-tools as there are upper bounds. I chose to remove the upper bounds altogether for the following reasons:

  • the usage of upper bounds is most often based on the presumption that future major versions will break untested code - a presumption that is usually incorrect
  • there is really no reason to install fprime-tools by itself, so the dependency versions are controlled by fprime's requirements.txt anyways
  • makes future updates easier

The only downside of this approach that I could identify is that there is a very small probability that by installing an external dependency in the virtual environment, that dependency will introduce an upgrade of one of fprime's dependency - and that upgrade might break things...
Let me know what you think

@thomas-bc
Copy link
Contributor Author

A good argument in favor of not introducing upper bounds unless it is actually proven that existing later versions are breaking is made here python-poetry/poetry#2731 (comment)

@LeStarch
Copy link
Collaborator

LeStarch commented Feb 1, 2023

Agreed.

@LeStarch LeStarch merged commit a6fbd2f into nasa:devel Feb 1, 2023
@thomas-bc thomas-bc deleted the update/requirements branch October 11, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants