Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FppMissingSupportFiles error message #117

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

thomas-bc
Copy link
Contributor

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s) nasa/fprime#1888
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Fixes nasa/fprime#1888.

I wasn't sure about the wording, this is the best that I could come up with in a concise manner. Let me know if you can think of better.

@LeStarch
Copy link
Collaborator

It seems like the commands should work independently of current working directory. Do they not do this?

@thomas-bc
Copy link
Contributor Author

The command is looking for the fpp-input-list under the build cache in the same context as where it is ran from. So if the current directory does not define FPP files, fpp-input-list is not generated by CMake in that context, and the command errors.
https://github.com/fprime-community/fprime-tools/blob/0c668dc8145ef5b806f6f892723ca5694f00d58a/src/fprime/fpp/common.py#L78-L81

@LeStarch LeStarch merged commit f53f0a1 into nasa:devel Feb 28, 2023
@thomas-bc thomas-bc deleted the fix/issue/1888 branch October 11, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Error Message with FPP Check
2 participants