Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle whitespaces in format command #121

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

thomas-bc
Copy link
Contributor

Originating Project/Creator
Affected Component
Affected Architectures(s) format
Related Issue(s) nasa/fprime#1939
Has Unit Tests (y/n)
Builds Without Errors (y/n) Y
Unit Tests Pass (y/n) Y
Documentation Included (y/n)

Change Description

Handles whitespaces in between FPrime access modifiers and the colon, such as PRIVATE:. This will also catch newlines, so patterns like

PRIVATE
:

which are technically correct are handled and formatted correctly.

Note: the output of the formatting tool is not being altered. That is, a PRIVATE : input will result in a PRIVATE: output, which is the correct formatting.

Rationale

Fixes nasa/fprime#1939

@thomas-bc thomas-bc added the bug Something isn't working label Mar 21, 2023
@thomas-bc thomas-bc requested a review from LeStarch March 21, 2023 17:07
@LeStarch LeStarch merged commit 65892de into nasa:devel Mar 29, 2023
@thomas-bc thomas-bc deleted the fix/format-whitespace branch October 11, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fprime-util Format Fails to Recoginze PRIVATE :
2 participants